Re: [PATCH] ARM: imx: imx8mn-ddr4-evk: Add ethernet support

[Marek Vasut]

On 3/2/21 8:53 AM, Jagan Teki wrote:
On Sat, Feb 27, 2021 at 6:21 PM Marek Vasut <ma...@denx.de> wrote:

On 2/27/21 8:54 AM, Jagan Teki wrote:
Hi Marek,

On Sat, Feb 27, 2021 at 3:44 AM Marek Vasut <ma...@denx.de> wrote:

Add support for ethernet on the imx8mn-ddr4-evk.

Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: Fabio Estevam <feste...@gmail.com>
Cc: Peng Fan <peng....@nxp.com>
Cc: Stefano Babic <sba...@denx.de>
---
   arch/arm/dts/imx8mn-evk.dtsi            |  1 +
   board/freescale/imx8mn_evk/imx8mn_evk.c | 41 +++++++++++++++++++++++--
   configs/imx8mn_ddr4_evk_defconfig       |  8 +++++
   3 files changed, 47 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi
index 76d042a4cf0..416fadb22b1 100644
--- a/arch/arm/dts/imx8mn-evk.dtsi
+++ b/arch/arm/dts/imx8mn-evk.dtsi
@@ -53,6 +53,7 @@
          pinctrl-0 = <&pinctrl_fec1>;
          phy-mode = "rgmii-id";
          phy-handle = <&ethphy0>;
+       phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;

I believe this is phy reset-gpio to be part of mdio child node. any
idea why it added in fec1 node?

Try $ git grep phy-reset drivers/net/ , that should clarify it all.
In short, FEC in U-Boot still uses legacy bindings.

True. I think it's better to add this property on -u-boot.dtsi which
helps to maintain Linux bindings.

The reset GPIO is not specific to U-Boot in any way, so no.
Instead, the Linux DT bindings should be updated too, but that's a 
separate topic.