On Sat, Feb 20, 2021 at 04:54:50AM -0700, Simon Glass wrote:
> Hi Bin,
>
> On Thu, 18 Feb 2021 at 08:58, Bin Meng <bmeng...@gmail.com> wrote:
> >
> > Commit e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI
> > regions")
> > changes 'struct pci_controller'.regions from pre-allocated array of
> > regions to dynamically allocated, which unfortunately broken lots of
> > boards that still use the non-DM PCI driver.
> >
> > This patch changes the non-DM fsl_pci_init driver to dynamically
> > allocate the regions, just like what's done in the pci uclass driver.
> >
> > Fixes: e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI
> > regions")
> > Signed-off-by: Bin Meng <bmeng...@gmail.com>
> >
> > ---
> >
> > Changes in v2:
> > - drop the revert patch of commit e002474158d1
> > - new patch: pci: fsl_pci_init: Dynamically allocate the PCI regions
> >
> > drivers/pci/fsl_pci_init.c | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> Reviewed-by: Simon Glass <s...@chromium.org>
>
> But I think it would be better to disable PCI on these devices
> (Kconfig depends on BROKEN) until the maintainer converts it to DM.I don't think that will work here and I suspect disabling PCI will lead to a ton of other build problems. I'm going to try and finish up a branch that removes all of the DM_MMC fail to convert boards (which has a lot of overlap with other fail to converts) and then we can see what's missing still for DM_PCI and some others. -- Tom
signature.asc
Description: PGP signature
