Hello Sean, Lukasz, On 07.02.21 00:49, Sean Anderson wrote: > On 2/6/21 12:37 PM, Lukasz Majewski wrote: >> Hi Sean, >> >>> On 2/5/21 9:46 AM, Lukasz Majewski wrote: >>> > Hi Sean, >>> > >>> >> This adds support for partitions of the form "dev.hwpart:part" and >>> >> "dev#partname". This allows one to flash to eMMC boot partitions >>> >> without having to use CONFIG_FASTBOOT_MMC_BOOT1_SUPPORT. It also >>> >> allows one to flash to an entire device without needing >>> >> CONFIG_FASTBOOT_MMC_USER_NAME. Lastly, one can also flash MMC >>> >> devices other than CONFIG_FASTBOOT_FLASH_MMC_DEV. >>> > >>> > This patch series causes following build errors: >>> > >>> https://dev.azure.com/lukma633/U-Boot/_build/results?buildId=20&view=results >>> >>> Yes, I saw those errors; they should be addressed in v5. >>> >>> > >>> > I saw the v5 of this patch series. Could you check if it pass with >>> > green the CI tests? >>> >>> It is building at [1]. >>> >>> [1] >>> https://dev.azure.com/u-boot/u-boot/_build/results?buildId=1748&view=results. >>> >> >> Interesting as >> https://dev.azure.com/lukma633/U-Boot/_build/results?buildId=22&view=logs&j=425537f6-562f-5a62-0856-6c59be70cbe4&t=62b0f1ee-aadf-504c-f243-098b7c952989 >> >> >> Still shows errors after applying patch v5 version. > > It looks like it's due to the following construct in fastboot.h > > #if CONFIG_IS_ENABLED(FASTBOOT_CMD_OEM_BOOTBUS) > FASTBOOT_COMMAND_OEM_BOOTBUS, > #if CONFIG_IS_ENABLED(FASTBOOT_UUU_SUPPORT) > FASTBOOT_COMMAND_ACMD, > FASTBOOT_COMMAND_UCMD, > #endif > > Which was added in 427f563 ("fastboot: add UUU command UCmd and ACmd support") > > It seems like Heiko made an error while rebasing, CCing him.
Yes, sorry... once not triggered azure build before posting... I send a v4, after azure build succeeds. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
