On Thu, Feb 04, 2021 at 03:28:59PM +0000, Aleksandar Gerasimovski wrote: > The SELI8 design is a new tdm service unit card for Hitachi-Powergrids > XMC and FOX product lines. > > It is based on NXP LS1021 SoC and it provides following interfaces: > - IFC interface for NOR, NAND and external FPGA's > - 1 x RGMII ETH for debug purposes > - 2 x SGMII ETH for management communication via back-plane > - 1 x uQE HDLC for management communication via back-plane > - 1 x I2C for peripheral devices > - 1 x SPI for peripheral devices > - 1 x UART for debug logging > > It is foreseen that the design will be later re-used for another XMC and > FOX service cards with similar SoC requirements. > > Signed-off-by: Rainer Boschung <rainer.bosch...@hitachi-powergrids.com> > Signed-off-by: Matteo Ghidoni <matteo.ghid...@hitachi-powergrids.com> > Signed-off-by: Aleksandar Gerasimovski > <aleksandar.gerasimov...@hitachi-powergrids.com> [snip] > +#ifndef __ASSEMBLY__ > +void set_sda(int state); > +void set_scl(int state); > +int get_sda(void); > +int get_scl(void); > +#endif
As a pre-req clean-up, please put these in a proper header file under board/keymile/common/ and #include as needed and not in the per-board config.h files. [snip] > +/* > + * Environment > + */ > + > +#define CONFIG_SYS_REDUNDAND_ENVIRONMENT > +#define CONFIG_ENV_ADDR_REDUND (CONFIG_ENV_ADDR - > CONFIG_ENV_SECT_SIZE) Environment is handled via Kconfig, please correct this and audit the config.h file for other things that are handled via Kconfig now. Thanks! -- Tom
signature.asc
Description: PGP signature
