On 31/01/21 07:34PM, Sean Anderson wrote: > This prints some basic metadata about the SPI memory op. This information > may be used to debug SPI drivers (e.g. determining the expected SPI mode). > It is also helpful for verifying that the data on the wire matches the data > intended to be transmitted (e.g. with a logic analyzer). The opcode is > printed with a format of %02Xh to match the notation commonly used in flash > datasheets. > > Signed-off-by: Sean Anderson <sean...@gmail.com> > --- > > drivers/spi/spi-mem.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c > index c095ae9505..eb83c11910 100644 > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -220,6 +220,12 @@ int spi_mem_exec_op(struct spi_slave *slave, const > struct spi_mem_op *op) > int ret; > int i; > > + dev_dbg(slave->dev, "exec %02Xh %u-%u-%u addr=%llx wait=%u len=%u\n", > + op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth, > + op->data.buswidth, op->addr.val, > + op->dummy.buswidth ? op->dummy.nbytes * 8 / op->dummy.buswidth > : 0,
SPI MEM deals with dummy bytes not cycles [0]. Just print them directly instead of converting them to cycles first. Also agree with Bin that "dummy cycles=" (or dummy bytes if you are printing bytes directly) is clearer. [0] For now. This might change later. See https://lore.kernel.org/linux-mtd/6396018a-485f-6eb4-7742-bdb5c4335...@microchip.com/ With these fixed, Reviewed-by: Pratyush Yadav <p.ya...@ti.com> > + op->data.nbytes); > + > if (!spi_mem_supports_op(slave, op)) > return -ENOTSUPP; > -- Regards, Pratyush Yadav Texas Instruments Inc.
