Thanks, I would post another. :-p
Lei
On Sun, Oct 10, 2010 at 2:42 AM, Wolfgang Denk <w...@denx.de> wrote:
> Dear Lei Wen,
>
> In message <1286618288-14552-1-git-send-email-lei...@marvell.com> you wrote:
>> When use the CONFIG_ENV_IS_NOWHERE, I met such issue:
>> Using default environment
>>
>> *** Warning - bad CRC, using default environment
>>
>> Signed-off-by: Lei Wen <lei...@marvell.com>
>> ---
>> common/env_common.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/common/env_common.c b/common/env_common.c
>> index 88f068c..10131c7 100644
>> --- a/common/env_common.c
>> +++ b/common/env_common.c
>> @@ -238,7 +238,6 @@ void env_relocate (void)
>> #else
>> show_boot_progress (-60);
>> #endif
>> - set_default_env("!bad CRC");
>> } else {
>> env_relocate_spec ();
>> }
>
> NAK.
>
> This fix is wrong, as it removes the call to set_default_env() also in
> the cases where it's needed. Instead, please move down the "#endif"
> after this line.
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
> This is now. Later is later.
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
