Hi Dario, On Sun, 24 Jan 2021 at 09:50, Dario Binacchi <dario...@libero.it> wrote: > > > Hi Simon, > > > Il 24/01/2021 03:03 Simon Glass <s...@chromium.org> ha scritto: > > > > > > Hi Dario, > > > > On Sat, 23 Jan 2021 at 11:27, Dario Binacchi <dario...@libero.it> wrote: > > > > > > The patch allows you to call the read/write functions set during probing > > > without having to check the type of access at runtime. It also adds > > > functions for 8-bit registers access. > > > > > > Signed-off-by: Dario Binacchi <dario...@libero.it> > > > --- > > > > > > drivers/pinctrl/pinctrl-single.c | 98 ++++++++++++++++++++++++-------- > > > 1 file changed, 73 insertions(+), 25 deletions(-) > > > > I'm not really keen on this. A switch() statement is not expensive and > > function pointers add indirection/confusion and use more space. > > I think however it is better to create two static functions for > reading/writing > operations (with a switch() statement inside). So as not to replicate the > code. > Do you agree?
Yes that sounds good to me. Regards, Simon
