On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote:
> Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and
> CONFIG_ACPIGEN=n fails with
>
> ld.bfd: cmd/built-in.o: in function `do_acpi_items':
> cmd/acpi.c:162: undefined reference to `acpi_dump_items'
>
> Add the missing configuration dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> ---
> cmd/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 0625ee4050..928a2a0a2d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -84,7 +84,8 @@ menu "Info commands"
>
> config CMD_ACPI
> bool "acpi"
> - default y if ACPIGEN
> + depends on ACPIGEN
> + default y
Shouldn't be rather
default ACPIGEN
?
> help
> List and dump ACPI tables. ACPI (Advanced Configuration and Power
> Interface) is used mostly on x86 for providing information to the
> --
> 2.29.2
>
--
With Best Regards,
Andy Shevchenko
