On 14.12.20 18:03, Heinrich Schuchardt wrote: > On 14.12.20 17:24, matthias....@kernel.org wrote: >> From: Matthias Brugger <mbrug...@suse.com> >> >> We find the iProc RNG200 in the Raspberry Pi 4. Add it to all it's >> config so that it can be used. >> >> Signed-off-by: Matthias Brugger <mbrug...@suse.com> > > After applying this patch series to origin/next ddaa9497858 > > make configs/rpi_arm64_defconfig > > gives me > > CONFIG_RNG_SANDBOX=y > CONFIG_RNG_IPROC200=n >
Forget the above. Something went wrong on my side. -- If you do not select DM_RNG, RNG_IPROC200 will not be selected. Please, configure the devices. Then run 'make savedefconfig' and copy defconfig to the original defconfig to get all the changes. Best regards Heinrich > >> >> --- >> >> configs/rpi_4_32b_defconfig | 1 + >> configs/rpi_4_defconfig | 1 + >> configs/rpi_arm64_defconfig | 1 + >> drivers/rng/iproc_rng200.c | 1 - >> 4 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig >> index 5ddd838fd5..b8cd0acf2d 100644 >> --- a/configs/rpi_4_32b_defconfig >> +++ b/configs/rpi_4_32b_defconfig >> @@ -58,3 +58,4 @@ CONFIG_PHYS_TO_BUS=y >> CONFIG_ADDR_MAP=y >> CONFIG_SYS_NUM_ADDR_MAP=2 >> CONFIG_OF_LIBFDT_OVERLAY=y >> +CONFIG_RNG_IPROC200=y >> diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig >> index 2590d0a696..9bde5b43d8 100644 >> --- a/configs/rpi_4_defconfig >> +++ b/configs/rpi_4_defconfig >> @@ -56,3 +56,4 @@ CONFIG_SYS_WHITE_ON_BLACK=y >> CONFIG_CONSOLE_SCROLL_LINES=10 >> CONFIG_PHYS_TO_BUS=y >> CONFIG_OF_LIBFDT_OVERLAY=y >> +CONFIG_RNG_IPROC200=y >> diff --git a/configs/rpi_arm64_defconfig b/configs/rpi_arm64_defconfig >> index 2639219a1a..42b7ec33c7 100644 >> --- a/configs/rpi_arm64_defconfig >> +++ b/configs/rpi_arm64_defconfig >> @@ -50,3 +50,4 @@ CONFIG_SYS_WHITE_ON_BLACK=y >> CONFIG_CONSOLE_SCROLL_LINES=10 >> CONFIG_PHYS_TO_BUS=y >> CONFIG_OF_LIBFDT_OVERLAY=y >> +CONFIG_RNG_IPROC200=y >> diff --git a/drivers/rng/iproc_rng200.c b/drivers/rng/iproc_rng200.c >> index 1063f43953..378f6cf48d 100644 >> --- a/drivers/rng/iproc_rng200.c >> +++ b/drivers/rng/iproc_rng200.c >> @@ -50,7 +50,6 @@ static void iproc_rng200_enable(struct >> iproc_rng200_platdata *pdata, bool enable >> val &= ~RNG_CTRL_RNG_RBGEN_ENABLE; >> >> writel(val, rng_base + RNG_CTRL_OFFSET); >> - >> } >> >> static void iproc_rng200_restart(struct iproc_rng200_platdata *pdata) >> >
