Hi Stefan, Thanks for your review.
I've looked into the usage of the kw_gpio driver. The soft_i2c part I mentioned in the commit appeared to be specific to my board configuration. I've replaced the usage of that driver with the DM based i2c-gpio driver there. All the usage of the kw_gpio functions is in board-specific code. I think the kw_gpio driver can be deprecated and board maintainers could update their code. Kind regards, Harm -----Original Message----- From: Stefan Roese <s...@denx.de> To: Harm Berntsen <harm.bernt...@nedap.com>, u-boot@lists.denx.de <u-boot@lists.denx.de> Subject: Re: [PATCH] gpio: Add support for DM GPIO for Kirkwood Date: Sat, 28 Nov 2020 11:08:43 +0100 Hi Harm, On 27.11.20 22:56, Harm Berntsen wrote: > The Armada driver also works on Nedap's ax8008 Kirkwood board with a > Marvell 88F6180 CPU. The original commit of that driver, > 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this > driver > would be suitable for Kirkwood. Well, this was really a long time ago. ;) > This driver does not completely replace the Kirkwood specific driver > as > there are still dependencies on that driver(i.e. soft_i2c.c. in our > case). So what work needs to be doney to completely replace the old legacy kw_gpio driver and remove it completely? Could you perhaps tackle it as well? Other than that: Reviewed-by: Stefan Roese <s...@denx.de> Thanks, Stefan > Signed-off-by: Harm Berntsen <harm.bernt...@nedap.com> > CC: Stefan Roese <s...@denx.de> > --- > > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 202fcc6f47..1f41bd3d55 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -374,7 +374,7 @@ config SIFIVE_GPIO > > config MVEBU_GPIO > bool "Marvell MVEBU GPIO driver" > - depends on DM_GPIO && ARCH_MVEBU > + depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD) > default y > help > Say yes here to support Marvell MVEBU (Armada XP/38x) > GPIOs. > Viele Grüße, Stefan
