Hi Heinrich, [...] > > > > + */ > > > +#define TPM2_NUM_PCR_BANKS 16 > > > + > > > +/* Definition of (UINT32) TPM2_CAP Constants */ > > > +#define TPM2_CAP_PCRS 0x00000005U > > > +#define TPM2_CAP_TPM_PROPERTIES 0x00000006U > > > + > > > +/* Definition of (UINT32) TPM2_PT Constants */ > > > +#define PT_GROUP (u32)(0x00000100) > > > +#define PT_FIXED (u32)(PT_GROUP * 1) > > > +#define TPM2_PT_MANUFACTURER (u32)(PT_FIXED + 5) > > > +#define TPM2_PT_PCR_COUNT (u32)(PT_FIXED + 18) > > > +#define TPM2_PT_MAX_COMMAND_SIZE (u32)(PT_FIXED + 30) > > > +#define TPM2_PT_MAX_RESPONSE_SIZE (u32)(PT_FIXED + 31) > > > > All these definitions are all copied from the "TCG TSS2.0 Overview and > > Common Structures Specification". I am missing a reference to the > > copyright notice of the spec. I think the best thing to do would be > > placing the TCG copyrighted code into a separate include that is > > included in tpm_v2.h. Please, check with Tom if the license contradicts > > GPL. Especially the following sentence seems problematic: > > > > "THE COPYRIGHT LICENSES SET FORTH ABOVE DO NOT REPRESENT ANY FORM OF > > LICENSE OR WAIVER, EXPRESS OR IMPLIED, BY ESTOPPEL OR OTHERWISE, WITH > > RESPECT TO PATENT RIGHTS HELD BY TCG MEMBERS (OR OTHER THIRD PARTIES) > > THAT MAY BE NECESSARY TO IMPLEMENT THIS SPECIFICATION OR OTHERWISE." > > > > Cf. https://fedoraproject.org/wiki/Licensing/TCGL > > > > Ok will do
So I talked to Tom and he suggested we have a look at linux, or any other project that uses those. I can't find any copyright claims in include/linux/tpm.h, apart from a pointer to the spec. I don't think splitting the changes to a new file is a good idea. Most of the existing definitions of the file are part of the same document. Maybe just updating the copyright properly is the right thing to do? [...] Regards /Ilias
