Hi Cduffinx, On Thu, 5 Nov 2020 at 14:26, cduffinx <cooperx.duf...@intel.com> wrote: > > modify the designware_i2c_xfer function to use 1 byte per > address, it was set to 0 before which makes it think its > reading a register type. Added offset of where it is > supposed to read from. Before it was always reading from > offset 0 despite specifying the offset in the higher level > function. > > Signed-off-by: Cooper Duffin <cooperx.duf...@intel.com> > Signed-off-by: cduffinx <cooperx.duf...@intel.com> > --- > > drivers/i2c/designware_i2c.c | 5 +++-- > drivers/i2c/i2c-uclass.c | 1 + > include/i2c.h | 1 + > 3 files changed, 5 insertions(+), 2 deletions(-) >
Thanks for the patch! Is there a test that was failing before (test/dm/i2c.c) or should we add a new one to catch this? Regards, Simon