Dear York Sun, In message <1285696512.30239.14.ca...@oslab-l1> you wrote: > On Tue, 2010-09-28 at 19:31 +0200, Wolfgang Denk wrote: > > > > -int memory_post_test (int flags) > > > +__attribute__((weak)) > > > +int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t > > > *phys_offset) > > > > phys_offset is unused here. Drop it? > > > > The phys_offset is not used by _this_ weak function but it is used by > another function implemented in the third patch. Is it OK to leave the > unused phys_offset here?
What does the compiler say? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He'd heard her use that sweet, innocent tone of voice before. It meant that, pretty soon, there was going to be trouble. - Terry Pratchett, _Truckers_ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot