Hi Sean, On Mon, 12 Oct 2020 at 10:56, Sean Anderson <[email protected]> wrote: > > On 10/11/20 11:35 PM, Simon Glass wrote: > > On Sat, 10 Oct 2020 at 13:43, Sean Anderson <[email protected]> wrote: > >> > >> Checkpatch complains about using #ifdef for CONFIG variables. > >> > >> Signed-off-by: Sean Anderson <[email protected]> > >> --- > >> > >> (no changes since v1) > >> > >> cmd/log.c | 4 ++-- > >> test/log/log_test.c | 2 +- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > > > > You can ignore this warning. > > > > Perhaps it should be downgraded to a check instead of a warning? >
That sounds like a good idea. There are quite a few places where #if is needed, despite this useful exhortation. Regards, Simon
