Hi Marri, On Saturday 25 September 2010 04:04:14 tma...@apm.com wrote: > From: Tirumala Marri <tma...@apm.com> > > APM821XX is a new line of SoCs which are derivatives of > PPC44X family of processors. This patch adds support of CPU, cache, > tlb, 32k ocm, bootstraps, PLB and AHB bus.
Thanks. Please see below for some more comments. <snip> > +++ b/arch/powerpc/include/asm/apm821xx.h > @@ -0,0 +1,69 @@ > +/* > + * Copyright (c) 2010, Applied Micro Circuits Corporation > + * Author: Tirumala R Marri <tma...@apm.com> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > + * MA 02111-1307 USA > + */ > + > +#ifndef _APM821XX_H_ > +#define _APM821XX_H_ > + > +#define CONFIG_SDRAM_PPC4xx_IBM_DDR2 /* IBM DDR(2) controller */ Please add CONFIG_SYS_PERIPHERAL_BASE here and remove it from your board config header. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot