Hi Simon, -----"Simon Glass" <s...@chromium.org> schrieb: ----- > Betreff: [PATCH v3 02/57] x86: acpi: Add base asl files for common x86 devices > > Add common x86 ASL files, taken from coreboot. > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > (no changes since v1) > > arch/x86/include/asm/acpi/chromeos.asl | 108 +++++++++++++++++ > arch/x86/include/asm/acpi/cpu.asl | 25 ++++ > arch/x86/include/asm/acpi/cros_gnvs.asl | 29 +++++ > arch/x86/include/asm/acpi/lpc.asl | 141 ++++++++++++++++++++++ > arch/x86/include/asm/acpi/pci_osc.asl | 21 ++++ > arch/x86/include/asm/acpi/pcr.asl | 80 ++++++++++++ > arch/x86/include/asm/acpi/ramoops.asl | 32 +++++ > arch/x86/include/asm/acpi/sleepstates.asl | 12 +- > 8 files changed, 443 insertions(+), 5 deletions(-) > create mode 100644 arch/x86/include/asm/acpi/chromeos.asl > create mode 100644 arch/x86/include/asm/acpi/cpu.asl > create mode 100644 arch/x86/include/asm/acpi/cros_gnvs.asl > create mode 100644 arch/x86/include/asm/acpi/lpc.asl > create mode 100644 arch/x86/include/asm/acpi/pci_osc.asl > create mode 100644 arch/x86/include/asm/acpi/pcr.asl > create mode 100644 arch/x86/include/asm/acpi/ramoops.asl
There are recent (~June 2020) commits in coreboot which convert most ASL files to ASL 2.0. The ASL 2.0 syntax is much easier to read IMHO, and I think it would be good to update this patch to take advantage of the recent coreboot developments. See e.g. the commit at [1]. regards, Wolfgang [1] https://github.com/coreboot/coreboot/commit/03248033e7be6f81ad5b60ed21a60071aee32c67
