> -----Original Message-----
> From: Thirupathaiah Annapureddy <thir...@linux.microsoft.com>
> Sent: Wednesday, September 2, 2020 4:43 AM
> To: u-boot@lists.denx.de
> Cc: Maxim Sloyko <max...@google.com>; Marek Vasut <ma...@denx.de>;
> thir...@microsoft.com; thir...@linux.microsoft.com; Tom Rini
> <tr...@konsulko.com>; ChiaWei Wang <chiawei_w...@aspeedtech.com>;
> Ryan Chen <ryan_c...@aspeedtech.com>
> Subject: [PATCH v2] arm: dts: fix ast2500-evb inclusion for the correct soc
> family
>
> Include ast2500-evb.dtb for CONFIG_ASPEED_AST2500 instead of for all
> aspeed targets.
>
> ast2400 is based on ARM926EJ-S processor (ARMv5-architecture).
> ast2500 is based on ARM1176JZS processor (ARMv6-architecture).
> ast2600 is based on Cortex A7 processor (ARMv7-A architecture).
> Each of the above SOC is using a different ARM CPU(s) with different ARM
> architecture revision. It is not possible to support all 3 of these families
> in a
> single binary. So there is no need to build ast2500-evb.dtb for other SOC
> families.
>
> Signed-off-by: Thirupathaiah Annapureddy <thir...@linux.microsoft.com>
> ---
>
> Changes in v2:
> - Incorporated the feedback from Tom Rini and Ryan Chen.
>
> arch/arm/dts/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
> 7e29b9096b..33d40a05f9 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
>
> dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb
>
> -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb
> +dtb-$(CONFIG_ASPEED_AST2500) += ast2500-evb.dtb
>
I prefer keep the Makefile logic clear use one CONFIG_ARCH_ASPEED to make all
ASPEED SoC dtb.
And also align with kernel tree "
https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/Makefile";.
Another point of view, For example, There also have AST2520 SoC which share the
same CPU architecture with AST2500,
And that will need another CONFIG_ASPEED_AST2520, That will cause more
complicated dts Makefile.
> dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
>
> --
> 2.25.2
