This is preferred over #if because the compiler can check syntax even if
the feature is disabled. This cannot be used for CONFIG_CLK because
CONFIG_DW_WDT_CLOCK_KHZ is not defined on all platforms.

Signed-off-by: Sean Anderson <sean...@gmail.com>
Reviewed-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---

(no changes since v1)

 drivers/watchdog/designware_wdt.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/watchdog/designware_wdt.c 
b/drivers/watchdog/designware_wdt.c
index f25c8d9ab3..49cf861d46 100644
--- a/drivers/watchdog/designware_wdt.c
+++ b/drivers/watchdog/designware_wdt.c
@@ -136,17 +136,17 @@ static int designware_wdt_probe(struct udevice *dev)
        priv->clk_khz = CONFIG_DW_WDT_CLOCK_KHZ;
 #endif
 
-#if CONFIG_IS_ENABLED(DM_RESET)
-       struct reset_ctl_bulk resets;
+       if (CONFIG_IS_ENABLED(DM_RESET)) {
+               struct reset_ctl_bulk resets;
 
-       ret = reset_get_bulk(dev, &resets);
-       if (ret)
-               return ret;
+               ret = reset_get_bulk(dev, &resets);
+               if (ret)
+                       return ret;
 
-       ret = reset_deassert_bulk(&resets);
-       if (ret)
-               return ret;
-#endif
+               ret = reset_deassert_bulk(&resets);
+               if (ret)
+                       return ret;
+       }
 
        /* reset to disable the watchdog */
        return designware_wdt_stop(dev);
-- 
2.28.0

Reply via email to