On Tue, Sep 01, 2020 at 02:15:32PM +0800, Bin Meng wrote: > Hi Andy, > > On Thu, Aug 20, 2020 at 6:02 PM Andy Shevchenko > <andriy.shevche...@linux.intel.com> wrote: > > > > start.S does nothing and can be safely removed. Makefile is still being used > > by the build system, so simply drop the rule from it. > > > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > Reviewed-by: Simon Glass <s...@chromium.org> > > --- > > v2: added Rb tag(s) > > > > board/emulation/qemu-x86/Makefile | 2 -- > > board/emulation/qemu-x86/start.S | 8 -------- > > 2 files changed, 10 deletions(-) > > delete mode 100644 board/emulation/qemu-x86/start.S > > > > diff --git a/board/emulation/qemu-x86/Makefile > > b/board/emulation/qemu-x86/Makefile > > index 782e298b74ce..5af8d31d5840 100644 > > --- a/board/emulation/qemu-x86/Makefile > > +++ b/board/emulation/qemu-x86/Makefile > > @@ -1,5 +1,3 @@ > > # SPDX-License-Identifier: GPL-2.0+ > > # > > # Copyright (C) 2015, Bin Meng <bmeng...@gmail.com> > > - > > -obj-y += start.o > > Unfortunately this does not build. > > We possibly need to fix the top-level Makefile and promote the Kconfig > option for all boards?
Hmm... I believe that I left Makefile in order to make it build. Which configuration had you used to reproduce? Okay, I see linker error now. Let me look into the issue. -- With Best Regards, Andy Shevchenko
