Hi Gary, > Hi Lukasz, > > On Wed, Aug 26, 2020 at 11:36:51AM +0200, Lukasz Majewski wrote: > > Hi Gary, > > > > > Hi, > > > > > > Gentle ping on this patch. Hopefully Sam's email won't bounce this > > > time. > > > > You couldn't have better timing than now :-) > > > > I'm now testing PR for Tom [1] and your original patch was causing > > some issues (probably it was correct when it was posted, but it was > > my fault that I'm going to pull it in now - my apologizes). > > > > I've fixed it [2] - please check if this fix is OK. > > Actually it was wrong before too, thanks for catching it! > Reason is that I didn't build with FASTBOOT_FLASH_NAND config enabled > which I should have done to check the second part of the change...
Ok. I've found another issue with this patch - it has some issues with sunxi: drivers/fastboot/fb_getvar.c: In function 'getvar_get_part_info': +drivers/fastboot/fb_getvar.c:118:38: error: 'struct part_info' has no member named 'blksz' + 118 | *size = part_info->size * part_info->blksz; + | ^~ +make[3]: *** [drivers/fastboot/fb_getvar.o] Error 1 The whole CI run can be found here: https://travis-ci.org/github/lmajewski/u-boot-dfu/builds/721449368 > > > Now I'm hunting another issues with sandbox [3]. When fixed I will > > send the PR. > > Sounds good. Let me know if you need anything from me. I think that the best solution would be if I drop this patch from the series and send PR (after some CI testing) without it. If you manage to fix it ASAP, then I will pull it immediately. > > Regards, > Gary Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgp06UxoHS3cD.pgp
Description: OpenPGP digital signature
