On 8/7/20 9:50 PM, Tom Rini wrote: > On Fri, Aug 07, 2020 at 09:34:06PM +0200, Heinrich Schuchardt wrote: > >> On 7/31/20 11:42 PM, Tom Rini wrote: >>> On Fri, Jul 31, 2020 at 10:12:32AM -0400, Tom Rini wrote: >>> >>>> As part of the EFI self test we set and check the serial# variable. >>>> However, we should not be forcing this setting. In the case where we >>>> are allowed to change the variable it will change, and we will pass the >>>> test. In the case where we cannot change it, force may or may not be >>>> allowed, depending on further environment restrictions. Drop the -f >>>> flag here as we do not need it. >>>> >>>> Cc: Heinrich Schuchardt <xypron.g...@gmx.de> >>>> Signed-off-by: Tom Rini <tr...@konsulko.com> >>> >>> Applied to u-boot/master, thanks! >>> >> >> >> With this patch on the Pine64 LTS: >> >> => => setenv efi_selftest device tree >> => => setenv serial# Testing DT >> ## Error: Can't overwrite "serial#" >> ## Error inserting "serial#" variable, errno=1 >> => >> >> This worked without your patch. >> >> This patch does not solve any problem. > > This patch resolved the problems trying to use "env set -f" on platforms > where CONFIG_ENV_ACCESS_IGNORE_FORCE is unset and the variable is not > protected. With: > commit 0f036bf4b87e6416f5c4d23865a62a62d9073c20 > Author: Marek Vasut <ma...@denx.de> > Date: Tue Jul 7 20:51:33 2020 +0200 > > env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set > > applied those platforms fail efi_selftest. The answer I believe is that > on your platform serial# is protected so you do have to force > overwriting it in order to change it. This is not the case of all > platforms with a serial# variable.
So no problem is solved except Marek's fancy warning. Best regards Heinrich
