On 14.09.2010 16:53, Mike Frysinger wrote: > On Tuesday, September 14, 2010 10:50:08 Reinhard Meyer wrote: >> for JEDEC devices without and with extension bytes >> for non JEDEC devices >> Signed-off-by: Reinhard Meyer<u-b...@emk-elektronik.de> > > needs to be a blank line before s-o-b tags and friends > >> - * Licensed under the GPL-2 or later. > > this is unnecessary noise. drop this hunk.
Drop what? The removal? > >> + /* >> + * count the number of continuation bytes, but >> + * leave at least 3 bytes to the end of the buffer untouched >> + */ >> + for (shift = 0, idp = idbuf; >> + shift< (sizeof(idbuf) - 3)&& *idp == 0x7f; >> + shift++, idp++) >> + ; > > is the offset of 3 necessary ? seems a little fragile ... Any JEDEC device seems to have at least 3 bytes of ID. Unless we start passing the length of the remainder of idbuf we need to make sure the probe function can safely access 3 bytes. Reinhard _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
