On Tue, Aug 4, 2020 at 7:02 PM Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
>
> On 04.08.20 03:46, Bin Meng wrote:
> > On Tue, Aug 4, 2020 at 5:26 AM Heinrich Schuchardt <xypron.g...@gmx.de>
> > wrote:
> >>
> >> Building with CONFIG_SPL_SMP=n results in:
> >>
> >> arch/riscv/lib/spl.c: In function ‘jump_to_image_no_args’:
> >> arch/riscv/lib/spl.c:33:6:
> >> error: unused variable ‘ret’ [-Werror=unused-variable]
> >> 33 | int ret;
> >> | ^~~
> >>
> >> Define the variable ret as __maybe_unused.
> >>
> >> Fixes: 191636e44898 ("riscv: Introduce SPL_SMP Kconfig option for U-Boot
> >> SPL")
> >
> > This should be on the same line
>
> Commit messages should not exceed 75 characters. See scripts/checkpatch.pl:
True, for normal commit messages.
>
> WARN("COMMIT_LOG_LONG_LINE",
> "Possible unwrapped commit description (prefer a maximum 75 chars per
> line)\n" . $herecurr);
>
But this Fixes tag is special. I suspect 2 lines will break some
scripts that is handling this "Fixes" tag.
Regards,
Bin
