Dear Fabio,
On 7/26/20 4:53 PM, Fabio Estevam wrote:
> Hi Parthiban,
>
> Your patch looks great. Only some minor observations:
Thanks, fixed in v2.
>
> On Sun, Jul 5, 2020 at 12:48 PM Parthiban Nallathambi
> <parthi...@linumiz.com> wrote:
>
>> +#ifdef CONFIG_FEC_MXC
>> +
>> +#define ENET_CLK_PAD_CTRL (PAD_CTL_DSE_40ohm | PAD_CTL_SRE_FAST)
>> +#define ENET_PAD_CTRL (PAD_CTL_PUS_100K_UP | PAD_CTL_PUE | \
>> + PAD_CTL_SPEED_HIGH | PAD_CTL_DSE_48ohm | \
>> + PAD_CTL_SRE_FAST)
>> +#define MDIO_PAD_CTRL (PAD_CTL_PUS_100K_UP | PAD_CTL_PUE | \
>> + PAD_CTL_DSE_48ohm | PAD_CTL_SRE_FAST | \
>> + PAD_CTL_ODE)
>> +
>> +static iomux_v3_cfg_t const fec1_pads[] = {
>> + MX6_PAD_GPIO1_IO06__ENET1_MDIO | MUX_PAD_CTRL(MDIO_PAD_CTRL),
>> + MX6_PAD_GPIO1_IO07__ENET1_MDC | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_TX_DATA0__ENET1_TDATA00 | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_TX_DATA1__ENET1_TDATA01 | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_TX_EN__ENET1_TX_EN | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_TX_CLK__ENET1_REF_CLK1 |
>> MUX_PAD_CTRL(ENET_CLK_PAD_CTRL),
>> + MX6_PAD_ENET1_RX_DATA0__ENET1_RDATA00 | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_RX_DATA1__ENET1_RDATA01 | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_RX_ER__ENET1_RX_ER | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> + MX6_PAD_ENET1_RX_EN__ENET1_RX_EN | MUX_PAD_CTRL(ENET_PAD_CTRL),
>> +};
>> +
>> +static void setup_iomux_fec(void)
>> +{
>> + imx_iomux_v3_setup_multiple_pads(fec1_pads, ARRAY_SIZE(fec1_pads));
>> +}
>
> The FEC IOMUX configuration can be retrieved from the device tree
> since you use DM_ETH, so the FEC IOMUX board code can be dropeed.
>
>> +/* Miscellaneous configurable options */
>> +#define CONFIG_SYS_MEMTEST_START 0x80000000
>> +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_MEMTEST_START +
>> 0x10000000)
>
> These options have been moved to Kconfig since:
>
> commit 702de89cc6a34c1c23dd3d987b0472b2cecdb63c
> Author: Ashok Reddy Soma <ashok.reddy.s...@xilinx.com>
> Date: Mon May 4 15:26:21 2020 +0200
>
> treewide: mem: Move mtest related defines to Kconfig
>
> Move below defines which are used by mtest utility to Kconfig.
> CONFIG_SYS_MEMTEST_START
> CONFIG_SYS_MEMTEST_END
>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.s...@xilinx.com>
> Signed-off-by: Michal Simek <michal.si...@xilinx.com>
> [trini: Fix kmcoge5ne board, re-run migration as well]
> Signed-off-by: Tom Rini <tr...@konsulko.com>
>
> Thanks
>
--
Thanks,
Parthiban N
