Hi Rick, On Fri, Jun 26, 2020 at 1:53 PM Pragnesh Patel <pragnesh.pa...@sifive.com> wrote: > > >-----Original Message----- > >From: Bin Meng <bmeng...@gmail.com> > >Sent: 23 June 2020 11:00 > >To: Rick Chen <r...@andestech.com>; Simon Glass <s...@chromium.org>; > >Pragnesh Patel <pragnesh.pa...@sifive.com>; Sagar Kadam > ><sagar.ka...@sifive.com>; U-Boot Mailing List <u-boot@lists.denx.de> > >Cc: Bin Meng <bin.m...@windriver.com> > >Subject: [PATCH 1/5] sysreset: syscon: Don't assume default value for offset > >and mask property > > > >[External Email] Do not click links or attachments unless you recognize the > >sender and know the content is safe > > > >From: Bin Meng <bin.m...@windriver.com> > > > >Per the DT binding, <offset> is a required property. Let's abort the probe > >if it is > >missing. For the <mask> property, current codes assume a default value of > >zero, which is not correct either. > > > >Signed-off-by: Bin Meng <bin.m...@windriver.com> > >--- > > > > drivers/sysreset/sysreset_syscon.c | 14 ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > Reviewed-by: Pragnesh Patel <pragnesh.pa...@sifive.com>
Would you please take the remaining 3 patches soon? http://patchwork.ozlabs.org/project/uboot/list/?series=185161 Regards, Bin
