Hi Heinrich, > -----Original Message----- > From: U-Boot <u-boot-boun...@lists.denx.de> On Behalf Of Heinrich Schuchardt > Sent: Monday, July 13, 2020 10:36 PM > To: Simon Glass <s...@chromium.org>; U-Boot Mailing List > <u-boot@lists.denx.de> > Cc: Tom Rini <tr...@konsulko.com>; Bin Meng <bmeng...@gmail.com>; Masahiro > Yamada > <yamada.masah...@socionext.com>; Marek Vasut <marek.va...@gmail.com>; Vignesh > R <vigne...@ti.com>; > Michal Simek <michal.si...@xilinx.com>; Igor Opaniuk > <igor.opan...@gmail.com>; Heiko Schocher > <h...@denx.de>; Fabio Estevam <feste...@gmail.com>; Jagan Teki > <ja...@amarulasolutions.com> > Subject: Re: Using gerrit or github for review? > > On 13.07.20 20:25, Simon Glass wrote: > > Hi, > > > > At present U-Boot uses the mailing list for patch review. What do > > Currently we are using Patchwork to keep track of the review process: > > https://urldefense.com/v3/__https://patchwork.ozlabs.org/project/uboot/list/__;!!A4F2R9G_pg!M278QbuG4g > 5GiXV1lWK3mAP9aDJsCGRoLe1F_6XLKUSPb0lwIfYEVIdA5gU-HTUX$ > > > people think about trying out geritt or github for this? I'd be > > willing to do a trial with the -dm mailing list. > > > > My idea is that patman would email out the patches and also upload > > them to one of these systems. With geritt, emails are sent every time > > there is a review, but for github I'm not sure. > > Do we need an new tool? Managing reviews it supported by Gitlab. > > There is no need for patman in a process with any of the mentioned > tools. Gitlab, Gerrit, and Github send out mails to reviewers. > > The work flow with Gitlab and Gerrit that I have seen relied on a role > concept where only specific users of the system are reviewers. - Our > current process allows anybody to review. This is what I would like to keep.
Well anybody (I guess registered to the given instance users) may do a code-review, but only limited amount of people may vote for/against that change and then even fewer people may press the "merge" button. But in case of U-Boot only a tree maintainer may accept patches so that's OK. What is not clear for me if and how multi-level source trees might be implemented in either system. I mean so that the platform maintainer accepts a patch for this particular platform, then sends a PR to the upstream say arch maintainer and then arch maintainer sends PR to the Tom. -Alexey
