Hi Sebastien,
> >> index 0c9d9a366e..c7f8b80954 100644
> >> --- a/drivers/power/pmic/pca9450.c
> >> +++ b/drivers/power/pmic/pca9450.c
> >> @@ -80,7 +80,7 @@ static struct dm_pmic_ops pca9450_ops = { };
> >>
> >> static const struct udevice_id pca9450_ids[] = {
> >> - { .compatible = "nxp,pca9450a", .data = 0x35, },
> >> + { .compatible = "nxp,pca9450a", .data = 0x25, },
> >> { .compatible = "nxp,pca9450b", .data = 0x25, },
> >> { }
> >> };
> >> diff --git a/drivers/power/pmic/pmic_pca9450.c
> >> b/drivers/power/pmic/pmic_pca9450.c
> >> index 67a9090200..c0fb78c4cd 100644
> >> --- a/drivers/power/pmic/pmic_pca9450.c
> >> +++ b/drivers/power/pmic/pmic_pca9450.c
> >> @@ -23,7 +23,7 @@ int power_pca9450a_init(unsigned char bus)
> >> p->name = pca9450_name;
> >> p->interface = PMIC_I2C;
> >> p->number_of_regs = PCA9450_REG_NUM;
> >> - p->hw.i2c.addr = 0x35;
> >> + p->hw.i2c.addr = 0x25;
> >> p->hw.i2c.tx_num = 1;
> >> p->bus = bus;
> >
> > There was a thread to address this, but not take udevice_id into
> consideration.
> > Your version looks better.
>
> In that thread [1], it was suggested to merge both function
> power_pca9450{a,b}_init into one function power_pca9450_init.
>
> [1] https://lists.denx.de/pipermail/u-boot/2020-June/418123.html
>
You are right, indeed, the solution to merge the two functions
into a single one is more elegant!
> Regards,
>
> >
> > Reviewed-by: Peng Fan <peng....@nxp.com>
> >
> >>
> >> --
> >> 2.17.1
> >
>
>
> --
> Sébastien Szymanski, Armadeus Systems
> Software engineer
Regards,
Flavio
