Hi Marri,

On Wednesday 08 September 2010 04:06:27 tma...@apm.com wrote:
> From: Tirumala Marri <tma...@apm.com>
> 
> Add support code for bluestone board wth APM821XX processor based.
> This patch includes early board init, misc init, configure EBC,
> initializes UIC, MAKEALL, board.cfg and MAINTAINERS file.

One nitpicking comment below.

<snip>
 
> +/*
> + * Ethernet
> + */
> +#define CONFIG_IBM_EMAC4_V4    1
> +#define CONFIG_EMAC_PHY_MODE  EMAC_PHY_MODE_NONE_RGMII
> +#define CONFIG_HAS_ETH0
> +/* PHY address, See schematics  */
> +#define CONFIG_PHY_ADDR                      0x1f
> +/* reset phy upon startup       */
> +#define CONFIG_PHY_RESET             1
> +#define CONFIG_PHY_RESET_R

CONFIG_PHY_RESET_R is not referenced anywhere. Please remove it.

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to