Hi Wolfgang, On Wed, 1 Jul 2020 at 09:15, Wolfgang Wallner <wolfgang.wall...@br-automation.com> wrote: > > Hi Simon, > > -----"Simon Glass" <s...@chromium.org> schrieb: ----- > > > Betreff: [PATCH v1 33/43] x86: irq: Support flags for acpi_gpe > > > > This binding currently has a flags cell but it is not used. Make use of it > > to create ACPI tables for interrupts. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > arch/x86/cpu/acpi_gpe.c | 26 +++++++++++++++++++ > > .../interrupt-controller/x86-irq.h | 14 ++++++++++ > > 2 files changed, 40 insertions(+) > > create mode 100644 include/dt-bindings/interrupt-controller/x86-irq.h > > > > [snip] > > > diff --git a/include/dt-bindings/interrupt-controller/x86-irq.h > > b/include/dt-bindings/interrupt-controller/x86-irq.h > > new file mode 100644 > > index 0000000000..9e0b4612e1 > > --- /dev/null > > +++ b/include/dt-bindings/interrupt-controller/x86-irq.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright 2019 Google LLC > > + * > > + * This provides additional flags used by x86. > > + */ > > + > > +#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_X86_IRQ_H > > +#define _DT_BINDINGS_INTERRUPT_CONTROLLER_X86_IRQ_H > > + > > +#define X86_IRQ_TYPE_SHARED (1 << 4) > > +#define X86_IRQ_TYPE_WAKE (1 << 5) > > Nit: BIT(4) and BIT(4) ?
I can't use those in devicetree bindings unfortunately. Regards, SImon
