Hi Neil, On Thu, 2 Jul 2020 at 13:29, Neil Armstrong <narmstr...@baylibre.com> wrote: > > On 01/07/2020 18:09, Anand Moon wrote: > > Hi Neil, > > > > On Wed, 1 Jul 2020 at 20:16, Neil Armstrong <narmstr...@baylibre.com> wrote: > >> > >> On 01/07/2020 16:43, Anand Moon wrote: > >>> Hi Neil, > >>> > >>> On Wed, 1 Jul 2020 at 18:38, Neil Armstrong <narmstr...@baylibre.com> > >>> wrote: > >>>> > >>>> Hi, > >>>> > >>>> On 01/07/2020 13:31, Anand Moon wrote: > >>>>> Hi Neil, > >>>>> > >>>>> On Wed, 1 Jul 2020 at 13:22, Neil Armstrong <narmstr...@baylibre.com> > >>>>> wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> On 30/06/2020 18:02, Anand Moon wrote: > >>>>>>> Hi Neil, > >>>>>>> > >>>>>>> On Tue, 30 Jun 2020 at 18:30, Neil Armstrong > >>>>>>> <narmstr...@baylibre.com> wrote: > >>>>>>>> > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> On 30/06/2020 13:33, Anand Moon wrote: > >>>>>>>>> Hi Beniamino, > >>>>>>>>> > >>>>>>>>> On Wed, 6 May 2020 at 01:53, Beniamino Galvani > >>>>>>>>> <b.galv...@gmail.com> wrote: > >>>>>>>>>> > >>>>>>>>>> Hi, > >>>>>>>>>> > >>>>>>>>>> these two patches add initial u-boot support for Hardkernel > >>>>>>>>>> ODROID-C4. > >>>>>>>>>> > >>>>>>>>>> https://wiki.odroid.com/odroid-c4/odroid-c4 > >>>>>>>>>> > >>>>>>>>>> Beniamino Galvani (2): > >>>>>>>>>> arm: dts: import ODROID-C4 device tree > >>>>>>>>>> boards: amlogic: add ODROID-C4 support > >>>>>>>>>> > >>>>>>>>> > >>>>>>>>> Can you respin this patches, I would like to see these get merged in > >>>>>>>>> the current u-boot release > >>>>>>>>> > >>>>>>>>> -Anand > >>>>>>>>> > >>>>>>>> > >>>>>>>> The Odroid-C4 could re-use the new Odroid-N2 board support I > >>>>>>>> submitted at [1] > >>>>>>>> > >>>>>>>> Anand, is the MAC address stored stored the same way on the C4 ? > >>>>>>>> > >>>>>>>> Neil > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > >>>>>>> > >>>>>>> I gave this patches a try on latest u-boot but I cannot make my Odroid > >>>>>>> C4 to boot up uinsg microSD card and eMMC > >>>>>>> Here are the logs. > >>>>>> > >>>>>> The PHY config must be wrong and it misses the -u-boot.dtsi to enable > >>>>>> HDMI. > >>>>>> > >>>>>> Can you test my custodian test branch with my C4 support patchset ? > >>>>>> > >>>>>> https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic/-/tree/u-boot-amlogic-test > >>>>>> > >>>>>> This one is used in Armbian 5.4 release and our KernelCI lab. > >>>>>> > >>>>>> Neil > >>>>>> > >>>>> > >>>>> Thanks. > >>>>> > >>>>> There seems to be a typo in the build instructions in # > >>>>> doc/board/amlogic/odroid-c4.rst > >>>>> instead of *g12b*, it should be *g12a* > >>>>> > >>>>> See below I get following build warning, which I fix locally, > >>>>> > >>>>> ./buildc4c.sh: line 78: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> ./buildc4c.sh: line 81: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> ./buildc4c.sh: line 84: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> ./buildc4c.sh: line 87: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> ./buildc4c.sh: line 90: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> ./buildc4c.sh: line 92: > >>>>> /home/amoon/mainline/u-boot/amlogic/w400/odroid-c4/fip/g12b/aml_encrypt_g12a: > >>>>> No such file or directory > >>>>> > >>>>> After that fix I am able to boot my board using eMMC and microSD card. > >>>> > >>>> Thanks for testing, I'll push my serie rebased on v5.8-rc1 and fix this > >>>> typo. > >>>> > >>>> Neil > >>>> > >>> > >>> Thanks, I see the same issue with random mac address just like N2. > >> > >> Yes, my branch was not using the N2 board support with eFuses MAC readout, > >> can you test my last patchset I just sent ? It should use the MAC from > >> eFuses or > >> generate an unique address with the SoC serial number. > >> > > Thanks > > > >> Please apply the patch in [1] before the new Odroid-C4 serie. > >> > >> [1] > >> https://patchwork.ozlabs.org/project/uboot/patch/20200618144037.23392-1-narmstr...@baylibre.com/ > >> > >> Neil > > > > I do not know the reason but your patches are not showing up on u-boot > > patchwork. > > > > [0] https://patchwork.ozlabs.org/project/uboot/list/ > > Good question ! > > Neil > Now it's showing up on u-boot patchwork.
https://patchwork.ozlabs.org/project/uboot/list/?series=187096 -Anand
