Hi Bin, > -----Original Message----- > From: Bin Meng <bmeng...@gmail.com> > Sent: Wednesday, June 24, 2020 6:52 AM > To: Sagar Kadam <sagar.ka...@sifive.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Rick Chen > <r...@andestech.com>; Lukasz Majewski <lu...@denx.de>; Jagan Teki > <ja...@amarulasolutions.com>; Pragnesh Patel > <pragnesh.pa...@sifive.com>; Anup Patel <anup.pa...@wdc.com>; Simon > Glass <s...@chromium.org>; Sean Anderson <sean...@gmail.com> > Subject: Re: [PATCH v4 2/4] riscv: dts: hifive-unleashed-a00: add cpu aliases > > [External Email] Do not click links or attachments unless you recognize the > sender and know the content is safe > > Hi Sagar, > > On Sun, Jun 21, 2020 at 9:10 PM Sagar Shrikant Kadam > <sagar.ka...@sifive.com> wrote: > > > > Add cpu aliases to U-Boot specific dtsi for hifive-unleashed. > > Without aliases we see that the CPU device sequence numbers are set > > randomly and the cpu list/detail command will show it as follows: > > => cpu list > > 1: cpu@0 rv64imac > > 0: cpu@1 rv64imafdc > > 2: cpu@2 rv64imafdc > > 3: cpu@3 rv64imafdc > > 4: cpu@4 rv64imafdc > > Without this patch, my output does not show the cpu@0 node in the "cpu > list" output. > > Could you please clarify?
I guess my explanation for your query in cover letter follow's here to. I will repost this based on spl. Thanks, Sagar > > > > > Seems like CPU probing with dm-model also relies on aliases as > > observed in case spi. The fu540-c000-u-boot.dtsi has cpu0/1/2/3/4 > > nodes and so adding corresponding aliases we can ensure that cpu > > devices are assigned proper sequence as follows: > > => cpu list > > 0: cpu@0 rv64imac > > 1: cpu@1 rv64imafdc > > 2: cpu@2 rv64imafdc > > 3: cpu@3 rv64imafdc > > 4: cpu@4 rv64imafdc > > > > Signed-off-by: Sagar Shrikant Kadam <sagar.ka...@sifive.com> > > Reviewed-by: Pragnesh Patel <pragnesh.pa...@sifive.com> > > --- > > Regards, > Bin