On 22.06.20 11:16, Ilias Apalodimas wrote: > Hi Heincrich, > > Thanks for merging those. > > > Thanks > /Ilias > > > On Sat, Jun 20, 2020 at 12:56:15PM +0200, Heinrich Schuchardt wrote: >> We currently have two implementations of UEFI variables: >> >> * variables provided via an OP-TEE module >> * variables stored in the U-Boot environment >> >> Read only variables are up to now only implemented in the U-Boot >> environment implementation. >> >> Provide a common interface for both implementations that allows handling >> read-only variables. >> >> Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de> >> --- > > [...] > >> #include <u-boot/crc.h> >> >> @@ -30,20 +30,6 @@ static bool efi_secure_boot; >> static int efi_secure_mode; >> static u8 efi_vendor_keys; >> >> -#define READ_ONLY BIT(31) >> - >> -static efi_status_t efi_get_variable_common(u16 *variable_name, >> - const efi_guid_t *vendor, >> - u32 *attributes, >> - efi_uintn_t *data_size, void *data); >> - >> -static efi_status_t efi_set_variable_common(u16 *variable_name, >> - const efi_guid_t *vendor, >> - u32 attributes, >> - efi_uintn_t data_size, >> - const void *data, >> - bool ro_check); >> - > > Is there any commit I've missed prior to that? > I don't see efi_variable.h in the patchset or additions of > EFI_VARIABLE_READ_ONLY > >> /* >> * Mapping between EFI variables and u-boot variables: > > [...] > > > Rest of the changes look good
I will resend the patch. Please, fetch https://gitlab.denx.de/u-boot/custodians/u-boot-efi/-/tree/efi-2020-10 Best regards Heinrich > > Regards > /Ilias >
