>-----Original Message----- >From: Kuldeep Singh <kuldeep.si...@nxp.com> >Sent: Friday, June 19, 2020 3:40 PM >To: Joe Hershberger <joe.hershber...@ni.com>; u-boot@lists.denx.de; >Priyanka Jain <priyanka.j...@nxp.com> >Cc: Tom Rini <tr...@konsulko.com>; Schrempf Frieder ><frieder.schre...@kontron.de> >Subject: RE: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read API >to access flash memory > > >> -----Original Message----- >> From: Schrempf Frieder <frieder.schre...@kontron.de> >> Sent: Thursday, May 28, 2020 1:46 PM >> To: Kuldeep Singh <kuldeep.si...@nxp.com>; Joe Hershberger >> <joe.hershber...@ni.com>; u-boot@lists.denx.de >> Cc: Priyanka Jain <priyanka.j...@nxp.com>; Tom Rini >> <tr...@konsulko.com> >> Subject: [EXT] Re: [RESEND][Patch v4] net: pfe_eth: Use spi_flash_read >> API to access flash memory >> >> Caution: EXT Email >> >> On 28.05.20 08:12, Kuldeep Singh wrote: >> > Current PFE firmware access spi-nor memory directly. New spi-mem >> > framework does not support direct memory access. So, let's use >> > spi_flash_read API to access memory instead of directly using it. >> > >> > Signed-off-by: Kuldeep Singh <kuldeep.si...@nxp.com> >> > Reviewed-by: Frieder Schrempf <frieder.schre...@kontron.de> >> >> So this patch has been floating around for about half a year now with >> almost no attention from the maintainers! Several pings have been sent >> by the author without response. >> >> In fact this patch was blocking 91afd36f3802 ("spi: Transform the FSL >> QuadSPI driver to use the SPI MEM API") that has finally been merged, >> ignoring the fact that it will break ls1012a without this being applied too. >> >> I don't want to blame anyone, but I want to voice my disappointment >> and raise attention that something is obviously wrong here. > >Hi Priyanka, > >Could you please help in reviewing this patch. The idea/motivation of these >changes are taken from fm driver. >The said changes in fm are already accepted in commit 382c53f94631 ("net: >fm: add TFABOOT support"). >You may take a look at code here[1], line: 380. > >Thanks >Kuldeep >[1] https://gitlab.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fm/fm.c
Reviewed-by: Priyanka Jain <priyanka.j...@nxp.com> Joe, Kindly help to pick this patch. Regards Priyanka