Dear Thibaut Girka, In message <1282164515-28846-1-git-send-email-t...@sitedethib.com> you wrote: > During a few months, offsets of files in multi-file images were miscalculated, > this has been fixed by 02b9b22446e3d7ad6a6382be17a1ce79a7de589b, > but unfortunatly, some devices (I'm thinking of the Neo FreeRunner) are using > a broken version of U-Boot. > > This problem can easily be worked around at image creation time by adding one > byte of junk at the end of the first (and optionnally second) file, if its > size is a multiple of 4. > It's not really clean, but it shouldn't cause any problem. At least, I haven't > encountered any using this patch.
In addition to Detlev's comments a few questions: - Is my understanding correct that there is no problem with the current mainline code? - You mentioned that commit 02b9b22 (i. e. v1.3.3-rc3-46-g02b9b22) fixed the problem - can you please also state which commit introduced the problem? - If so, would it then not be better to update U-Boot on the devices that are running a broken version? As this patch is really adding a quirk for a specific version (or set of versions) of U-Boot only, but without general use for the current mainline code (on contrary, it's making the code more complex without benefit to most of us), I tend to reject this patch for mainline. If there has been one or more released versions with this problem present, we might consider a maintenance release for these, where we add the commit as a workaround. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot