On Fri, Jun 05, 2020 at 11:19:15AM -0400, Tom Rini wrote:
> On Sun, May 31, 2020 at 12:16:58AM +0200, Heinrich Schuchardt wrote:
>
> > In some of our Python tests we build disk images. Currently this involves
> > using the sudo command for losetup and mount. For some tests sudo is
> > not necessary if the command guestmount of package libguestfs-tools is
> > available. Another useful tool in libguestfs-tools is virt-make-fs.
> >
> > Generally we should get rid of using a root user for building and testing.
> > As a first step install libguestfs-tools in our Docker image.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
> > ---
> > Dockerfile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Dockerfile b/Dockerfile
> > index 4138415..20a861f 100644
> > --- a/Dockerfile
> > +++ b/Dockerfile
> > @@ -57,6 +57,7 @@ RUN apt-get update && apt-get install -y \
> > iasl \
> > imagemagick \
> > iputils-ping \
> > + libguestfs-tools \
> > libisl15 \
> > liblz4-tool \
> > libpixman-1-dev \
>
> I haven't applied this as in order to also convert any of the tests to
> libguestfs-tools based approaches, Azure/GitLab (or Travis even) can be
As far as I know, the only use of sudo can be seen in tests I added:
a test_fs
b test_efi_secboot
(a) has a flexible approach like:
if (tool_is_in_path('guestmount'):
...
else
check_call('sudo mount ...')
I also took a similar approach in (b) when I posted my patch,
but Heinrich deleted "non-sudo" part from my original code
when it was merged.
-Takahiro Akashi
> locally modified to point at your own fork of the image. If you really
> need me to push this change to unblock further conversion please let me
> know, thanks!
>
> --
> Tom
