Hi Marcin,

    The commit message is acceptable, but you will need to send a new V2 patch for this instead of reply this by the comment.


Thanks,

- Kever

On 2020/5/25 下午4:52, Marcin Juszkiewicz wrote:
RNG module works fine on RockPro64 so let's enable it by default.

=>  rng
00000000: 77 08 dd 04 2c 4d b8 cf 25 07 29 2d c0 ce 28 3b  w...,M..%.)-..(;
00000010: d4 5a 38 68 b1 40 97 59 b8 a5 7c 42 f8 4c 38 28  .Z8h.@.Y..|B.L8(
00000020: 25 20 0b 4b f0 1a d5 c1 e6 a2 c2 34 5a 5e 64 26  % .K.......4Z^d&
00000030: 41 8b d8 7e c4 d6 9e e3 da 0e 98 a2 2f 38 0d 9f  A..~......../8..

Signed-off-by: Marcin Juszkiewicz <mar...@juszkiewicz.com.pl>
---
  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 4 ++++
  configs/rockpro64-rk3399_defconfig        | 2 ++
  2 files changed, 6 insertions(+)

diff --git arch/arm/dts/rk3399-rockpro64-u-boot.dtsi 
arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
index deaa3efd39..824ee4e3ce 100644
--- arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
+++ arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
@@ -23,3 +23,7 @@
  &vdd_log {
        regulator-init-microvolt = <950000>;
  };
+
+&rng {
+       status = "okay";
+};
diff --git configs/rockpro64-rk3399_defconfig configs/rockpro64-rk3399_defconfig
index 53abce0057..04ba151475 100644
--- configs/rockpro64-rk3399_defconfig
+++ configs/rockpro64-rk3399_defconfig
@@ -43,6 +43,8 @@ CONFIG_REGULATOR_PWM=y
  CONFIG_REGULATOR_RK8XX=y
  CONFIG_PWM_ROCKCHIP=y
  CONFIG_RAM_RK3399_LPDDR4=y
+CONFIG_DM_RNG=y
+CONFIG_RNG_ROCKCHIP=y
  CONFIG_BAUDRATE=1500000
  CONFIG_DEBUG_UART_SHIFT=2
  CONFIG_ROCKCHIP_SPI=y


Reply via email to