A common problem when submitting a new uclass is to forget to add sandbox
tests. Add a warning for this.

Of course tests should always be added for new code, but this one seems to
be missed by nearly every new contributor.

Signed-off-by: Simon Glass <s...@chromium.org>
---

 scripts/checkpatch.pl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 93863c8f086..9dc42520e2d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2241,6 +2241,12 @@ sub pos_last_openparen {
 # Checks specific to U-Boot
 sub u_boot_line {
        my ($realfile, $line,  $herecurr) = @_;
+
+       # ask for a test if a new uclass ID is added
+       if ($realfile =~ /uclass-id.h/ && $line =~ /^\+/) {
+               WARN("NEW_UCLASS",
+                    "Possible new uclass - make sure to add a sandbox driver, 
plus a test in test/dm/<name>.c\n" . $herecurr);
+       }
 }
 
 sub process {
-- 
2.27.0.rc0.183.gde8f92d652-goog

Reply via email to