On Thursday, August 26, 2010 04:27:36 Reinhard Meyer wrote:
> 1. looking at spi_flash.c, shall I add the standard copyright,
> keeping atmel as author?

doesnt matter to me

> 2. I can find the following lengths of idcode used:
> atmel 2
> macronix 3
> ramtron 9
> spansion 5
> sst 3
> stmicro 4
> winbond 3
> 
> Do you really want to flexify this? Even before relocation 5 bytes
> more on stack would not be an issue...
> Of course, for me the 5/10 switch would work as well.

i would keep the 5/10 split

> It would involve the
>       debug("SF: Got idcode %02x %02x %02x %02x %02x\n", idcode[0],
>                       idcode[1], idcode[2], idcode[3], idcode[4]);
> as well. I can make that into a for() loop
> #ifdef DEBUG
>       printf("SF: Got idcode");
>       for (i=0; i<IDCODE_LEN; i++)
>               printf(" %02x", idcode[i]);
>       printf("\n");
> #endif

use print_buffer()
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to