Dear C Nauman,
On 25 August 2010 03:18, C Nauman <cnau...@diagraph.com> wrote:
> Minkyu,
remove it.
please write the commit msg only.
>
> - This patch adds generic support for the Samsung s3c2440 processor.
> Started from patch posted by Kevin Morfitt.
> - v2 Changed struct members to lower case
please move the change log under the --- line.
>
> Signed-off-by: Craig Nauman <cnau...@diagraph.com>
please add Kevin to Cc
> ---
> arch/arm/cpu/arm920t/s3c24x0/speed.c | 36 +-
> arch/arm/cpu/arm920t/s3c24x0/timer.c | 23 +-
> arch/arm/cpu/arm920t/s3c24x0/usb.c | 10 +-
> arch/arm/cpu/arm920t/s3c24x0/usb_ohci.c | 12 +-
> arch/arm/include/asm/arch-s3c24x0/s3c2440.h | 163 ++++++
> arch/arm/include/asm/arch-s3c24x0/s3c24x0.h | 672
> +++++++++++++----------
> arch/arm/include/asm/arch-s3c24x0/s3c24x0_cpu.h | 2 +
> board/mpl/vcma9/vcma9.c | 40 +-
> board/samsung/smdk2400/smdk2400.c | 28 +-
> board/samsung/smdk2410/smdk2410.c | 36 +-
> board/sbc2410x/sbc2410x.c | 44 +-
> board/trab/cmd_trab.c | 28 +-
> board/trab/rs485.c | 38 +-
> board/trab/trab.c | 66 ++--
> board/trab/trab_fkt.c | 142 +++---
> board/trab/tsc2000.c | 38 +-
> board/trab/tsc2000.h | 64 ++--
> board/trab/vfd.c | 86 ++--
> drivers/i2c/s3c24x0_i2c.c | 102 ++--
> drivers/mtd/nand/s3c2410_nand.c | 8 +-
> drivers/rtc/s3c24x0_rtc.c | 52 +-
> drivers/serial/serial_s3c24x0.c | 26 +-
> 22 files changed, 993 insertions(+), 723 deletions(-)
> create mode 100644 arch/arm/include/asm/arch-s3c24x0/s3c2440.h
Your patch have many style problems.
(total: 178 errors, 805 warnings, 2928 lines checked)
Please run checkpatch.pl.
I'll review your patch after you fix it.
>
> Minkyu Kang wrote:
>>
>> Dear C Nauman,
>>
>> On 23 August 2010 22:40, C Nauman <cnau...@diagraph.com> wrote:
>>
>>>
>>> This patch adds generic support for the Samsung s3c2440 processor.
>>> Started from patch posted 2009-06-19 by
>>> Kevin Morfitt. Then modified for changes in the code that have occurred
>>> since.
>>>
>>> Signed-off-by: Craig Nauman <cnauman <at> diagraph.com>
>>>
>>
>> Please fix the email address.
>> And could you please use the git format-patch?
>> so that we can see what are changed.
>>
>>
>>>
>>> ---
>>>
>>> diff --git a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
>>> b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
>>> index 15f53dd..d4abd24 100644
>>> --- a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
>>> +++ b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
>>> @@ -82,6 +82,10 @@ struct s3c24x0_interrupt {
>>> u32 SUBSRCPND;
>>> u32 INTSUBMSK;
>>> #endif
>>> +#ifdef CONFIG_S3C2440
>>> + u32 SUBSRCPND;
>>> + u32 INTSUBMSK;
>>> +#endif
>>> };
>>>
>>
>> We don't allow upper case structure members.
>> That is reason for why kevin sent clean-up patches.
>> Please fix it globally.
>>
>> Thanks.
>> Minkyu Kang.
>>
>
> --
> Craig Nauman
> Diagraph an ITW Company
> cnauman at diagraph dot com
>
>
Please remove last mail thread.
Thanks.
Minkyu Kang
--
from. prom.
www.promsoft.net
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
