Re: [PATCH v7 14/22] riscv: Add place-holder for driver compilation

[Jagan Teki]

On Mon, May 11, 2020 at 11:28 AM Pragnesh Patel
<pragnesh.pa...@sifive.com> wrote:
>
> >-----Original Message-----
> >From: Jagan Teki <ja...@amarulasolutions.com>
> >Sent: 10 May 2020 14:42
> >To: Pragnesh Patel <pragnesh.pa...@sifive.com>
> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra
> ><atish.pa...@wdc.com>; Palmer Dabbelt <palmerdabb...@google.com>; Bin
> >Meng <bmeng...@gmail.com>; Paul Walmsley <paul.walms...@sifive.com>;
> >Troy Benjegerdes <troy.benjeger...@sifive.com>; Anup Patel
> ><anup.pa...@wdc.com>; Sagar Kadam <sagar.ka...@sifive.com>; Rick Chen
> ><r...@andestech.com>
> >Subject: Re: [PATCH v7 14/22] riscv: Add place-holder for driver compilation
> >
> >[External Email] Do not click links or attachments unless you recognize the
> >sender and know the content is safe
> >
> >On Sun, May 3, 2020 at 2:47 PM Pragnesh Patel <pragnesh.pa...@sifive.com>
> >wrote:
> >>
> >> Hi Jagan,
> >>
> >> >-----Original Message-----
> >> >From: Jagan Teki <ja...@amarulasolutions.com>
> >> >Sent: 02 May 2020 21:58
> >> >To: Pragnesh Patel <pragnesh.pa...@sifive.com>
> >> >Cc: U-Boot-Denx <u-boot@lists.denx.de>; Atish Patra
> >> ><atish.pa...@wdc.com>; Palmer Dabbelt <palmerdabb...@google.com>;
> >Bin
> >> >Meng <bmeng...@gmail.com>; Paul Walmsley
> ><paul.walms...@sifive.com>;
> >> >Troy Benjegerdes <troy.benjeger...@sifive.com>; Anup Patel
> >> ><anup.pa...@wdc.com>; Sagar Kadam <sagar.ka...@sifive.com>; Rick
> >Chen
> >> ><r...@andestech.com>
> >> >Subject: Re: [PATCH v7 14/22] riscv: Add place-holder for driver
> >> >compilation
> >> >
> >> >[External Email] Do not click links or attachments unless you
> >> >recognize the sender and know the content is safe
> >> >
> >> >On Sat, May 2, 2020 at 3:38 PM Pragnesh Patel
> >> ><pragnesh.pa...@sifive.com>
> >> >wrote:
> >> >>
> >> >> Add place-holder for RISC-V fu540 CPU
> >> >>
> >> >> Signed-off-by: Pragnesh Patel <pragnesh.pa...@sifive.com>
> >> >> ---
> >> >>  arch/riscv/include/asm/arch-fu540/clk.h  | 14 +++++++++
> >> >> arch/riscv/include/asm/arch-fu540/gpio.h | 38
> >> >> ++++++++++++++++++++++++
> >> >
> >> >Where is it using exactly?
> >>
> >> "drivers/gpio/sifive-gpio.c"
> >
> >I mean which patch used these headers?
>
> This headers are necessary for existing SiFive drivers.
>
> Earlier CONFIG_SYS_CPU is "generic", so drivers use headers from " 
> arch/riscv/include/asm/arch-generic/" now
> We have changed the CONFIG_SYS_CPU to "fu540" so now drivers will use headers 
> from
> "arch/riscv/include/asm/arch-fu540/".

How can someone understand the patch if you don't have any commit
message explaining this? also add these headers to the patch that
introduces CONFIG_SYS_CPU. It makes more sense to use the code or
header which are relevant rather than a stale commit.

Jagan.