Hi Ezra,

On 04.05.20 20:12, Ezra Buehler wrote:
Hi Chris,

On 4 May 2020, at 10:04, Chris Packham <judge.pack...@gmail.com> wrote:

I think this would be better in the specific board dts files. Not every 
platform will want this in spl.

Thanks for the input, I can do that. However, please note that before,
the "spi0" node was under "internal-regs" which had the
"u-boot,dm-pre-reloc" property. Commit c265bbe4d (rm: sync armada-xp dts
files from Linux 5.0) moved the node out and removed the U-Boot-specific
property. The property was then added again to "internal-regs" with
commit "1718a9f3b7 (arm: mvebu: armada-370-xp.dtsi: Add "u-boot,
dm-pre-reloc" to "internal-regs") but not to the spi0 node. So basically
this patch restores the previous behavior. What is better?

U-Boot specific DT properties, like "u-boot,dm-pre-reloc" should be
added in U-Boot specific DT dtsi files, e.g.

armada-xp-synology-ds414-u-boot.dtsi

in this case. Such files are included seamlessly by the build system.
Take a look at this file as an example:

arch/arm/dts/armada-3720-uDPU-u-boot.dtsi

This makes it possible to sync the DT files with Linux and still
integrate U-Boot specifics.

Thanks,
Stefan

Reply via email to