On 4/30/20 4:43 AM, David Wu wrote:
> For others using, clk_rx and clk_tx may not be necessary,
> and their clock names are different.
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> @@ -1691,20 +1699,16 @@ static int eqos_probe_resources_stm32(struct udevice
> *dev)
> ret = clk_get_by_name(dev, "stmmaceth", &eqos->clk_master_bus);
> if (ret) {
> pr_err("clk_get_by_name(master_bus) failed: %d", ret);
> - goto err_probe;
> + return ret;
> }
>
> - ret = clk_get_by_name(dev, "mac-clk-rx", &eqos->clk_rx);
> - if (ret) {
> - pr_err("clk_get_by_name(rx) failed: %d", ret);
> - goto err_free_clk_master_bus;
> - }
> + ret = clk_get_by_name(dev, "mac_clk_rx", &eqos->clk_rx);
> + if (ret)
> + pr_warn("clk_get_by_name(rx) failed: %d", ret);
Oh... Judging by your email, you're trying to make this driver work on a
Rockchip system. However, you're editing an STM32-specific probe
function. You should introduce a new probe function for Rockchip if it
needs to work differently to the existing STM32 code.
Also, mac_clk_rx isn't a valid DT property name; they aren't supposed to
have _ in them. I don't see mac_clk_rx or mac-clk-rx in the DT binding
file in Documentation/bindings/net/rockchip-dwmac.txt the kernel. That
should probably be submitted/reviewed/applied before using the binding...
