Harald, sorry for the typo in the previous email.
On Wed, Apr 29, 2020 at 4:06 PM Harald Seiler <h...@denx.de> wrote: > > From: Marek Vasut <ma...@denx.de> > > Board files should not re-implement do_reset() to work around this > function not being defined in for specific configurations. Rather, > the fix is to compile in drivers which implement this properly. > This patch enables sysreset and watchdog drivers in SPL and ties > them together to implement the same as the do_reset() hack in the > board file, except correctly in the DM/DT framework. > > Signed-off-by: Marek Vasut <ma...@denx.de> > Cc: Fabio Estevam <feste...@gmail.com> > Cc: Flavio Suligoi <f.suli...@asem.it> > Cc: Harald Seiler <h...@denx.de> > Cc: Igor Opaniuk <igor.opan...@toradex.com> > Cc: Marcel Ziswiler <marcel.ziswi...@toradex.com> > Cc: Oleksandr Suvorov <oleksandr.suvo...@toradex.com> > Cc: Peng Fan <peng....@nxp.com> > Cc: Stefano Babic <sba...@denx.de> > --- > arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 12 ++++++++++++ > board/toradex/verdin-imx8mm/spl.c | 9 --------- > configs/verdin-imx8mm_defconfig | 5 +++++ > 3 files changed, 17 insertions(+), 9 deletions(-) > > diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > index e60b9faee442..fe6bb9bf03cf 100644 > --- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > +++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi > @@ -3,6 +3,14 @@ > * Copyright 2020 Toradex > */ > > +/ { > + wdt-reboot { > + compatible = "wdt-reboot"; > + wdt = <&wdog1>; > + u-boot,dm-spl; > + }; > +}; > + > &aips1 { > u-boot,dm-spl; > u-boot,dm-pre-reloc; > @@ -105,3 +113,7 @@ > &usdhc3 { > u-boot,dm-spl; > }; > + > +&wdog1 { > + u-boot,dm-spl; > +}; > diff --git a/board/toradex/verdin-imx8mm/spl.c > b/board/toradex/verdin-imx8mm/spl.c > index a5dc54082054..dc5bd84f332e 100644 > --- a/board/toradex/verdin-imx8mm/spl.c > +++ b/board/toradex/verdin-imx8mm/spl.c > @@ -169,12 +169,3 @@ void board_init_f(ulong dummy) > > board_init_r(NULL, 0); > } > - > -int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > -{ > - puts("resetting ...\n"); > - > - reset_cpu(WDOG1_BASE_ADDR); > - > - return 0; > -} > diff --git a/configs/verdin-imx8mm_defconfig b/configs/verdin-imx8mm_defconfig > index 590750e9b2d1..21f6aa308208 100644 > --- a/configs/verdin-imx8mm_defconfig > +++ b/configs/verdin-imx8mm_defconfig > @@ -38,6 +38,7 @@ CONFIG_SPL_SEPARATE_BSS=y > CONFIG_SPL_I2C_SUPPORT=y > CONFIG_SPL_POWER_SUPPORT=y > CONFIG_SPL_USB_HOST_SUPPORT=y > +CONFIG_SPL_WATCHDOG_SUPPORT=y > CONFIG_SYS_PROMPT="Verdin iMX8MM # " > # CONFIG_BOOTM_NETBSD is not set > CONFIG_CMD_ASKENV=y > @@ -94,5 +95,9 @@ CONFIG_DM_REGULATOR_FIXED=y > CONFIG_DM_REGULATOR_GPIO=y > CONFIG_MXC_UART=y > CONFIG_SYSRESET=y > +CONFIG_SPL_SYSRESET=y > CONFIG_SYSRESET_PSCI=y > +CONFIG_SYSRESET_WATCHDOG=y > CONFIG_DM_THERMAL=y > +# CONFIG_WATCHDOG is not set > +CONFIG_IMX_WATCHDOG=y > -- > 2.26.2 > Acked-by: Igor Opaniuk <igor.opan...@toradex.com> Thanks! -- Best regards - Freundliche GrĂ¼sse - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk