On 4/20/20 12:48 PM, Heinrich Schuchardt wrote:
> For non-root users mkfs.vfat is not in the search path at least on Debian.
> Hence when running 'make tests' a message indicates that file system tests
> have been skipped:
>
> SKIPPED [13] test/py/tests/test_fs/conftest.py:340: Setup failed for
> filesystem: fat16
>
> This message is not really helpful as the executed program is not
> indicated. Provide a more complete message like
>
> SKIPPED [13] test/py/tests/test_fs/conftest.py:340: Setup failed for
> filesystem: fat16.
> Command 'mkfs.vfat -F 16 build-sandbox/persistent-data/3GB.fat16.img'
> returned non-zero exit status 127.
> diff --git a/test/py/tests/test_fs/conftest.py
> b/test/py/tests/test_fs/conftest.py
> + pytest.skip('Setup failed for filesystem: ' + fs_type + \
> + '. {}'.format(err))
Wouldn't it be much simpler to avoid the format call:
... + fs_type + '. ' + err)
But either way the change seems conceptually fine.
