Hello Alex, Am 17.04.2020 um 03:38 schrieb Alex Nemirovsky:
From: Arthur Li <arthur...@cortina-access.com>Add I2C controller support for Cortina Access CAxxxx SoCs Signed-off-by: Arthur Li <arthur...@cortina-access.com> Signed-off-by: Alex Nemirovsky <alex.nemirov...@cortina-access.com> CC: Heiko Schocher <h...@denx.de> --- Changes in v5: None Changes in v4: - Utilize standard I2C macros from <i2c.h> - Return ETIMEDOUT in funcs that can timeout - Return i2c_xfer_init() result to caller of i2c_read() if it fails within i2c_read() execution - Fix misc. style guide conformance issues - Use printf() to report i2c_xfer() runtime errors instead of debug() Changes in v3: None Changes in v2: None MAINTAINERS | 4 + drivers/i2c/Kconfig | 7 + drivers/i2c/Makefile | 1 + drivers/i2c/i2c-cortina.c | 346 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/i2c/i2c-cortina.h | 84 +++++++++++ 5 files changed, 442 insertions(+) create mode 100644 drivers/i2c/i2c-cortina.c create mode 100644 drivers/i2c/i2c-cortina.h
Sorry one more nitpick ... could you please document the new devicetree binding in "doc/device-tree-bindings/i2c/"? Thanks! Beside of this, you can add my Reviewed-by: Heiko Schocher <h...@denx.de> bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
