Hello Mike,
On Wed, Aug 11, 2010 at 7:48 PM, Mike Frysinger <vap...@gentoo.org> wrote:
> Merge the other significant source of board name duplication with the new
> boards.cfg file. I cleaned up most targets, but the ARM and MIPS trees
> are such a mess than I didn't bother. If those maintainers care, they can
> take are of it.
>
> While we're at it, we can be a bit more clever in the LIST_xxx handling
> and avoid duplicating the list names too.
This is great.
> ---
> @@ -993,6 +748,22 @@ build_target() {
> ${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
> | tee -a ${LOG_DIR}/$target.MAKELOG
> }
> +build_targets() {
> + for t in "$@" ; do
> + # If a LIST_xxx var exists, use it. But avoid variable
> + # expansion in the eval when a board name contains certain
> + # characters that the shell interprets.
> + case ${t} in
> + *[-+=]*) list= ;;
> + *) list=`eval echo '${LIST_'$t'}'` ;;
I know that $() is not needed here since there is no nesting or
embedding of \\; but I noticed that the LIST_ expansion introduced in
the rest of this patch used $() so I think that this eval should be
changed to $() also.
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometrics.ca
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
