Hi Jaehoon, On 27/03/2020 05:08, Jaehoon Chung wrote: > Enable SDHCI_SDMA configuration. > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> > Reviewed-by: Peng Fan <peng....@nxp.com> > Reviewed-by: Minkyu Kang <mk7.k...@samsung.com> > --- > configs/rpi_4_32b_defconfig | 1 + > configs/rpi_4_defconfig | 1 + > 2 files changed, 2 insertions(+) >
Please address the comments I had in v3 of this patch: https://patchwork.ozlabs.org/patch/1261047/ If you just send a new version of the patch that won't convince me to take it. We will need to make sure that we are fine with patch. Especially I'm concerned about the limitation of the device to only be able to access the first GiB of RAM for DMA. I'd like to see an explanation why this won't happen on U-Boot. Regards, Matthias > diff --git a/configs/rpi_4_32b_defconfig b/configs/rpi_4_32b_defconfig > index 72cda5d949..7189914606 100644 > --- a/configs/rpi_4_32b_defconfig > +++ b/configs/rpi_4_32b_defconfig > @@ -25,6 +25,7 @@ CONFIG_DFU_MMC=y > CONFIG_DM_KEYBOARD=y > CONFIG_DM_MMC=y > CONFIG_MMC_SDHCI=y > +CONFIG_MMC_SDHCI_SDMA=y > CONFIG_MMC_SDHCI_BCM2835=y > CONFIG_DM_ETH=y > CONFIG_BCMGENET=y > diff --git a/configs/rpi_4_defconfig b/configs/rpi_4_defconfig > index 6d148dab07..454d28ea2b 100644 > --- a/configs/rpi_4_defconfig > +++ b/configs/rpi_4_defconfig > @@ -25,6 +25,7 @@ CONFIG_DFU_MMC=y > CONFIG_DM_KEYBOARD=y > CONFIG_DM_MMC=y > CONFIG_MMC_SDHCI=y > +CONFIG_MMC_SDHCI_SDMA=y > CONFIG_MMC_SDHCI_BCM2835=y > CONFIG_DM_ETH=y > CONFIG_BCMGENET=y >
