Hi Simon, On Fri, Mar 27, 2020 at 12:20 AM Simon Glass <[email protected]> wrote: > > HI Bin, > > On Wed, 25 Mar 2020 at 01:25, Bin Meng <[email protected]> wrote: > > > > Hi Simon, > > > > On Tue, Mar 24, 2020 at 9:45 PM Simon Glass <[email protected]> wrote: > > > > > > At present we query the memory map on boards which don't support it. Fix > > > this by only doing it on Apollo Lake. > > > > > > > I wonder isn't this check already covered in mrccache_get_region() below: > > > > ret = dm_spi_get_mmap(dev, &map_base, &map_size, &offset); > > if (!ret) { > > entry->base = map_base; > > } else { > > ret = dev_read_u32_array(dev, "memory-map", reg, 2); > > if (ret) > > return log_msg_ret("Cannot find memory map\n", ret); > > entry->base = reg[0]; > > } > > Yes it is, so long as dm_spi_get_mmap() returns an error, as it does > with my patch.
So does ich_get_mmap_bus() returns 0 on chromebook_link? Regards, Bin
