-----Original Message----- From: Thierry Reding <tred...@nvidia.com> Sent: Thursday, March 19, 2020 1:04 AM To: Tom Warren <twar...@nvidia.com> Cc: u-boot@lists.denx.de; Stephen Warren <swar...@nvidia.com>; Jonathan Hunter <jonath...@nvidia.com>; tomcwarren3...@gmail.com Subject: Re: [PATCH 1/2] net: rt8169: WAR for DHCP not getting IP after kernel boot/reboot
On Tue, Mar 17, 2020 at 01:07:15PM -0700, twar...@nvidia.com wrote: > From: Tom Warren <twar...@nvidia.com> > > This is a WAR for DHCP failure after rebooting from the L4T kernel. > The r8169.c kernel driver is setting bit 19 of the rt816x HW register > 0xF0, which goes by FuncEvent and MISC in various driver source/datasheets. > That bit is called RxDv_Gated_En in the r8169.c kernel driver. Clear > it here at the end of probe to ensure that U-Boot can get an IP > assigned via DHCP. > > Signed-off-by: Tom Warren <twar...@nvidia.com> > --- > drivers/net/rtl8169.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Is this still needed? In my old p3450 branch that I worked on to get Porg up and running I don't have this patch. It's also not in my local development tree that I typically use to boot Tegra186 and earlier boards. That branch works fine on the Jetson Nano, so I don't think this is needed anymore. I vaguely recall that I determined that this was fixed some other way, but unfortunately I don't remember the exact details. Thierry [Tom] I'll retest as part of my Nano rework of your original patch, Thierry. So you've done network boot, then rebooted from the kernel (sudo reboot), and attempted net boot again and seen it work OK, w/an IP assigned by DHCP, etc.? (not static IP). It's also possible that something in the kernel RT8169 driver has changed, and it's not setting the bit anymore. ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
