Dear Marek Vasut, In message <1281119471-30895-1-git-send-email-marek.va...@gmail.com> you wrote: > The new driver is a complete rewrite. It uses the MMC framework and should > support both pxa2xx and pxa3xx.
Did you even compile test this driver? > Tested on: > - Palm Tungsten|C PXA255 > - Aeronix ZipitZ2 PXA270 > - Marvell Zylonite 300 PXA300 Really? I would expect the compiler throws a bunch of error messages due to missing semicolons, like > + ret = pxa_mmc_wait(MMC_STAT_CLK_EN) > + if (ret) > + return ret; here. > + ret = pxa_mmc_wait(MMC_STAT_DATA_TRAN_DONE) > + if (ret) > + return ret; And here. > + ret = pxa_mmc_wait(MMC_STAT_DATA_TRAN_DONE) > + if (ret) > + return ret; And here. > + /* Wait until the data are really written to the card */ > + ret = pxa_mmc_wait(MMC_STAT_PRG_DONE) > + if (ret) > + return ret; And here. > + ret = pxa_mmc_wait(MMC_STAT_END_CMD_RES) > + if (ret) > + return ret; And here. Does this really compile for you? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The complexity of software is an essential property, not an acciden- tal one. Hence, descriptions of a software entity that abstract away its complexity often abstract away its essence. - Fred Brooks, Jr. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
